Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: allow typescript to run on tests #1124

Merged
merged 3 commits into from
Sep 19, 2024
Merged

build: allow typescript to run on tests #1124

merged 3 commits into from
Sep 19, 2024

Conversation

huwshimi
Copy link
Collaborator

@huwshimi huwshimi commented Sep 3, 2024

Done

  • Fixed typescript so that it runs on test files.
  • Added typescript build config so that definitions aren't built for test files.
  • Updated babel to not include test files in the build.

@webteam-app
Copy link

Demo

Jenkins

demos.haus

@mas-who
Copy link
Contributor

mas-who commented Sep 19, 2024

LGTM thanks for the fix and reducing bundle size! 👍

@huwshimi huwshimi merged commit 5187fb9 into canonical:main Sep 19, 2024
11 checks passed
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mas-who mas-who mas-who approved these changes

Assignees
No one assigned
Labels
Maintenance 🔨 released Review: Code +1 Review: Percy +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huwshimi @webteam-app @mas-who